feat: Modularise and document analytics endpoints #2288
Merged
+235
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/analytics-api-module
branch
from
b10457c to
097816e
Compare
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Oct 10, 2023
| - analytics | ||
| responses: | ||
| "204": | ||
| description: Successful response - no awaited response from server |
There was a problem hiding this comment.
nit: can either the post description or response description be tweaked to include "via the Beacon API" or similar so it's more clear why our "success" here is no awaited response?
There was a problem hiding this comment.
Very good catch - change made! Will merge when CI is happy 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I needed a break from E2E tests and it seemed worthwhile getting this quickly tidied up before @Mike-Heneghan may want to expand on this.